Poissonmultivi

[lauradmartens]

Hi @martinkim0,

I had some time and added the Poisson loss also to the MultiVI model (POISSONMULTIVI) to the external models.

Addresses #2257 for Poisson likelihood.

[lauradmartens]

I added the option to have separate size factors for RNA and ATAC, not sure if this is the best way.

[codecov]

Codecov Report

Attention: Patch coverage is 78.36991% with 138 lines in your changes missing coverage. Please review.

Project coverage is 84.34%. Comparing base (cfa3d83) to head (1105a0c).
Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
src/scvi/external/poissonmultivi/_model.py	72.28%	74 Missing ⚠️
src/scvi/external/poissonmultivi/_module.py	82.51%	64 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2735      +/-   ##
==========================================
- Coverage   84.60%   84.34%   -0.26%     
==========================================
  Files         178      181       +3     
  Lines       15052    15690     +638     
==========================================
+ Hits        12734    13234     +500     
- Misses       2318     2456     +138     

Files with missing lines	Coverage Δ
src/scvi/_constants.py	100.00% <100.00%> (ø)
src/scvi/external/__init__.py	100.00% <100.00%> (ø)
src/scvi/external/poissonmultivi/__init__.py	100.00% <100.00%> (ø)
src/scvi/external/poissonmultivi/_module.py	82.51% <82.51%> (ø)
src/scvi/external/poissonmultivi/_model.py	72.28% <72.28%> (ø)

[canergen]

Quick check looks good. Can you explain, why we don't inherit from MULTIVI and MULTIVAE?

[canergen]

Closing here due to inactivity. We have our own proposed Poisson distribution in multiVI that will be merged in the near future.