Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MULTIVI Mudata Minification #3039

Open
wants to merge 96 commits into
base: main
Choose a base branch
from

Conversation

ori-kron-wis
Copy link
Collaborator

@ori-kron-wis ori-kron-wis commented Nov 12, 2024

multivi & totalvi minification on mudata

@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Nov 12, 2024
@ori-kron-wis ori-kron-wis added this to the scvi-tools 1.2 milestone Nov 12, 2024
@ori-kron-wis ori-kron-wis self-assigned this Nov 12, 2024
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need to update the changlog

@ori-kron-wis ori-kron-wis changed the title feat: TOTALVI & MULTIVI Mudata Minification feat: MULTIVI Mudata Minification Dec 31, 2024
@ori-kron-wis
Copy link
Collaborator Author

This branch is still waiting for logic fix for multivi

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 3.79147% with 406 lines in your changes missing coverage. Please review.

Project coverage is 80.92%. Comparing base (a435561) to head (37d7996).

Files with missing lines Patch % Lines
src/scvi/module/_multivae copy.py 0.00% 404 Missing ⚠️
src/scvi/data/fields/_arraylike_field.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3039      +/-   ##
==========================================
- Coverage   82.95%   80.92%   -2.04%     
==========================================
  Files         181      182       +1     
  Lines       15433    15850     +417     
==========================================
+ Hits        12803    12826      +23     
- Misses       2630     3024     +394     
Files with missing lines Coverage Δ
src/scvi/model/_multivi.py 76.20% <100.00%> (+1.12%) ⬆️
src/scvi/data/fields/_arraylike_field.py 92.34% <66.66%> (-0.77%) ⬇️
src/scvi/module/_multivae copy.py 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants