Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve speed for transfer fields if using many categories. #3132

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

canergen
Copy link
Member

@canergen canergen commented Jan 9, 2025

No description provided.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.95%. Comparing base (a435561) to head (2504569).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (a435561) and HEAD (2504569). Click for more details.

HEAD has 35 uploads less than BASE
Flag BASE (a435561) HEAD (2504569)
38 3
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3132      +/-   ##
==========================================
- Coverage   89.77%   82.95%   -6.82%     
==========================================
  Files         181      181              
  Lines       15494    15433      -61     
==========================================
- Hits        13909    12803    -1106     
- Misses       1585     2630    +1045     
Files with missing lines Coverage Δ
src/scvi/data/fields/_dataframe_field.py 96.66% <100.00%> (ø)

... and 29 files with indirect coverage changes

@canergen canergen requested a review from ori-kron-wis January 12, 2025 06:32
@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Jan 12, 2025
@ori-kron-wis ori-kron-wis added this to the scvi-tools 1.2 milestone Jan 12, 2025
@ori-kron-wis ori-kron-wis merged commit 820c987 into main Jan 12, 2025
24 of 25 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Jan 12, 2025
ori-kron-wis pushed a commit that referenced this pull request Jan 12, 2025
…ields if using many categories.) (#3140)

Backport PR #3132: feat: Improve speed for transfer fields if using many
categories.

Co-authored-by: Can Ergen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-merge: backport to 1.2.x on-merge: backport to 1.2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants