Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Load pyro models correctly with restoring param_store #3133

Closed
wants to merge 29 commits into from

Conversation

canergen
Copy link
Member

No description provided.

LevyNat and others added 29 commits June 4, 2024 01:53
@canergen canergen closed this Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 58.82353% with 56 lines in your changes missing coverage. Please review.

Project coverage is 82.70%. Comparing base (a435561) to head (e6b99cc).

Files with missing lines Patch % Lines
src/scvi/model/base/_archesmixin.py 32.14% 38 Missing ⚠️
src/scvi/model/base/_de_core.py 13.33% 13 Missing ⚠️
src/scvi/model/base/_differential.py 89.13% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a435561) and HEAD (e6b99cc). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (a435561) HEAD (e6b99cc)
32 3
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
- Coverage   89.77%   82.70%   -7.07%     
==========================================
  Files         181      181              
  Lines       15494    15504      +10     
==========================================
- Hits        13909    12823    -1086     
- Misses       1585     2681    +1096     
Files with missing lines Coverage Δ
src/scvi/model/_multivi.py 75.17% <ø> (+0.08%) ⬆️
src/scvi/model/_peakvi.py 88.03% <ø> (+0.93%) ⬆️
src/scvi/model/_totalvi.py 87.82% <ø> (ø)
src/scvi/model/base/_base_model.py 91.97% <100.00%> (-1.17%) ⬇️
src/scvi/model/base/_rnamixin.py 94.46% <100.00%> (ø)
src/scvi/module/_scanvae.py 85.38% <100.00%> (ø)
src/scvi/module/_totalvae.py 88.01% <100.00%> (ø)
src/scvi/module/base/_base_module.py 88.43% <100.00%> (-3.68%) ⬇️
src/scvi/train/_callbacks.py 85.21% <100.00%> (+0.42%) ⬆️
src/scvi/train/_trainingplans.py 93.63% <100.00%> (+0.01%) ⬆️
... and 3 more

... and 27 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants