correct shuffling of annotations in nhood enrichment #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates: - [github.com/pre-commit/mirrors-mypy: v1.6.1 → v1.7.1](pre-commit/mirrors-mypy@v1.6.1...v1.7.1) - [github.com/psf/black: 23.10.1 → 23.11.0](psf/black@23.10.1...23.11.0) - [github.com/pre-commit/mirrors-prettier: v3.0.3 → v4.0.0-alpha.3](pre-commit/mirrors-prettier@v3.0.3...v4.0.0-alpha.3) - [github.com/astral-sh/ruff-pre-commit: v0.1.4 → v0.1.6](astral-sh/ruff-pre-commit@v0.1.4...v0.1.6)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #775 +/- ##
==========================================
+ Coverage 69.86% 69.87% +0.01%
==========================================
Files 39 39
Lines 5479 5498 +19
Branches 1023 1031 +8
==========================================
+ Hits 3828 3842 +14
- Misses 1360 1363 +3
- Partials 291 293 +2
|
timtreis
requested changes
Dec 8, 2023
tests/graph/test_utils.py
Outdated
| cluster_annotations = rng.choice([1, 2, 3, 4], size=(size,)) | ||
| else: | ||
| cluster_annotations = rng.choice(["X", "Y", "Z"], size=(size,)) | ||
| rs = np.random.RandomState(seed) |
There was a problem hiding this comment.
Why don't you use your rng from above here?
| Shuffled annotations. | ||
| """ | ||
| cluster_annotation_output = np.empty(libraries.shape, dtype=cluster_annotation.dtype) | ||
| for c in libraries.cat.categories: |
There was a problem hiding this comment.
categories will always be small, right? Or is there the need to vectorized?
There was a problem hiding this comment.
categories should always be small yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please search among the Pull requests before creating one.
Description
How has this been tested?
Closes