-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions to compute a developer's last activity #275
base: dev
Are you sure you want to change the base?
Conversation
While a function to compute the first activity per person and activity type already existed, this was not the case for the last activity. Instead of copying the code from first-activity computation, reuse the code by establishing an additional helper function for aggregating activity dates. This is used by first and last activity now, and could potentially also be used for other aggregations (e.g., to compute the mid date of a person's activities). Signed-off-by: Thomas Bock <[email protected]>
42f17ee
to
dbed901
Compare
@bockthom I have had a closer look at the changes submitted in this PR and I could not find major issues with it! I only spotted some minor stylistic ones, I will list them below. |
f4e0214
to
b2b32d8
Compare
Similar to enhancing first-activity computation by last-activity computation in the previous commit, this can also be done for the corresponding vertex attributes. We now have a new function to attribute the "last.activity" vertex attribute. Both functions to add first and last activity as a vertex attribute make use of a commonly used helper function that allows to add an aggregated activity date as a vertex attribute. Signed-off-by: Thomas Bock <[email protected]>
b2b32d8
to
4a593dc
Compare
Thank you @bockthom for correcting the misalignments all over |
The elements in the coronet/util-networks-covariates.R Lines 938 to 943 in 4a593dc
Same goes for the elements in the coronet/util-networks-covariates.R Lines 635 to 642 in 4a593dc
Lastly, these parameters are just overall off: coronet/util-networks-covariates.R Lines 1147 to 1151 in 4a593dc
Note: As you did not edited these lines, it would not let me create a regular review comment and I had to resort to this. |
Signed-off-by: Thomas Bock <[email protected]>
The tests cover the new "last.activity" vertex attribute, which shall implicitly also cover the last-activity data computation. Signed-off-by: Thomas Bock <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
4a593dc
to
75796c4
Compare
I've fixed the three misalignments that you have spotted @maxloeffler (at least, I hope so). If all the misalignments you have spotted are fixed now and if you agree with my descriptions in the NEWS.md, I'd be happy if you could also formally approve this PR 😄 |
Prerequisites
showcase.R
with respect to my changes.dev
.Description
While we already have functionality to compute the first activity per developer, there was no functionality yet to compute the last activity per developer. With this PR, functionality to compute the last activity per developer is added.
Changelog
Added