Skip to content

Commit

Permalink
Merge pull request #2038 from Curtisjnes/feature_enableMobileMenu
Browse files Browse the repository at this point in the history
bump ace-builds up to 1.36.3 and added their new enableMobileMenu option
  • Loading branch information
securingsincity authored Nov 2, 2024
2 parents f3263ca + 2ac06cb commit 71222ef
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 5 deletions.
20 changes: 20 additions & 0 deletions example/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ class App extends Component {
fontSize: 14,
lineHeight: 19,
showGutter: true,
enableMobileMenu: true,
showPrintMargin: true,
highlightActiveLine: true,
enableSnippets: false,
Expand Down Expand Up @@ -253,6 +254,23 @@ class App extends Component {
Enable Live Autocomplete
</label>
</p>
</div>
<div className="field">
<p className="control">
<label className="checkbox">
<input
type="checkbox"
checked={this.state.enableMobileMenu}
onChange={e =>{
this.setBoolean(
"enableMobileMenu",
e.target.checked
)
}}
/>
Enable Mobile Menue
</label>
</p>
</div>
<div className="field">
<p className="control">
Expand Down Expand Up @@ -346,6 +364,7 @@ class App extends Component {
setOptions={{
useWorker: false,
enableBasicAutocompletion: this.state.enableBasicAutocompletion,
enableMobileMenu: this.state.enableMobileMenu,
enableLiveAutocompletion: this.state.enableLiveAutocompletion,
enableSnippets: this.state.enableSnippets,
showLineNumbers: this.state.showLineNumbers,
Expand Down Expand Up @@ -376,6 +395,7 @@ class App extends Component {
enableBasicAutocompletion: ${this.state.enableBasicAutocompletion},
enableLiveAutocompletion: ${this.state.enableLiveAutocompletion},
enableSnippets: ${this.state.enableSnippets},
enableMobileMenu: ${this.state.enableMobileMenu},
showLineNumbers: ${this.state.showLineNumbers},
tabSize: 2,
}}/>
Expand Down
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"react"
],
"dependencies": {
"ace-builds": "^1.32.8",
"ace-builds": "^1.36.3",
"diff-match-patch": "^1.0.5",
"lodash.get": "^4.4.2",
"lodash.isequal": "^4.5.0",
Expand Down
1 change: 1 addition & 0 deletions src/ace.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export interface IAceEditorProps {
debounceChangePeriod?: number;
enableBasicAutocompletion?: boolean | string[];
enableLiveAutocompletion?: boolean | string[];
enableMobileMenu?: boolean;
tabSize?: number;
value?: string;
placeholder?: string;
Expand Down

0 comments on commit 71222ef

Please sign in to comment.