Implement Monthly Reminder Service #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of directly passing individual fields to the updateProfile function, refactor the logic to use a single updateData object. This object contains the updated fields for the profile, such as primary_email, first_name, last_name, and image_url. This change improves code readability and maintainability. Related to sef-global#165
- Moved monthly checking service functions to a dedicated service file (monthlyChecking.service.ts). - Moved monthly checking controller functions to a dedicated controller file (monthlyChecking.controller.ts). - Updated import paths and references to reflect the new file structure. - Improved code organization and maintainability by separating concerns.
Monthly checking feature
…mpts, introduce new mentee reminders logic
… for processing and scheduling reminders, and enhance reminder service logic
… status enums, and implement dynamic next reminder date calculation
anjula-sack
requested changes
Nov 16, 2024
| @@ -56,6 +56,7 @@ | |||
| "@types/jsonwebtoken": "^9.0.2", | |||
| "@types/multer": "^1.4.11", | |||
| "@types/node": "^20.1.4", | |||
| "@types/node-cron": "^3.0.11", | |||
There was a problem hiding this comment.
Remove this
Suggested change
| "@types/node-cron": "^3.0.11", |
|
|
||
| const today = new Date() | ||
| const todayDateString = today.toDateString() | ||
| console.log(todayDateString) |
There was a problem hiding this comment.
Suggested change
| console.log(todayDateString) |
| }) | ||
| .getMany() | ||
|
|
||
| console.log(newMentees) |
There was a problem hiding this comment.
Suggested change
| console.log(newMentees) |
| @@ -8,5 +8,5 @@ | |||
| "experimentalDecorators": true, | |||
| "emitDecoratorMetadata": true | |||
| }, | |||
| "include": ["src/**/*.ts", "test/", "jest.config.ts","mocks.ts"] | |||
| "include": ["src/**/*.ts", "test/", "jest.config.ts","mocks.ts", "src/migrations/1730893653817-MonthlyChecking.ts"] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #176
This issue involves enhancing the
EmailReminderServiceto ensure that email reminders are scheduled and processed correctly, with proper handling of retries and failures.Goals
Approach
Screenshots
Checklist
Related PRs
Test environment
Learning