[STRATCONN-5399]-Handles refresh token retry for multistatus responses #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2674 +/- ##
==========================================
+ Coverage 78.47% 78.91% +0.44%
==========================================
Files 1032 1085 +53
Lines 18590 21252 +2662
Branches 3521 4257 +736
==========================================
+ Hits 14588 16772 +2184
- Misses 2825 3297 +472
- Partials 1177 1183 +6 ☔ View full report in Codecov by Sentry. |
varadarajan-tw
force-pushed
the
mulistatus-handle-retries
branch
from
1eff09d to
2b4f95c
Compare
varadarajan-tw
force-pushed
the
mulistatus-handle-retries
branch
from
2b4f95c to
57b6f4f
Compare
varadarajan-tw
commented
Jan 13, 2025
| @@ -901,7 +901,7 @@ export class Destination<Settings = JSONObject, AudienceSettings = JSONObject> { | |||
| return result | |||
| } | |||
|
|
|||
| const onFailedAttempt = async (error: ResponseError & HTTPError) => { | |||
| const onFailedAttempt = async (error: ResponseError | HTTPError) => { | |||
There was a problem hiding this comment.
error can either be ResponeError or HTTPError. It can never be a mix of both.
varadarajan-tw
commented
Jan 13, 2025
| } | ||
| return true | ||
| } | ||
| return await retry<Result[]>(run, { retries: MAX_ATTEMPTS, onFailedAttempt, shouldRetry }) |
There was a problem hiding this comment.
Another approach I could have taken is to throw an exception if any of the events failed with 401 error and re-use the existing flow. However, that means we would end up reporting other 400 errors as 401 as well. Therefore, decided to go ahead with this approach of intentionally handling multistatus response. Open to any other thoughts.
itsarijitray
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles 401 refresh token retries for multistatus responses. Previously, we threw 401 exception for refresh token retries. However, for handling multistatus, developers now return a
MultistatusResponseobject fromperformBatchblock. This PR ensures that if any of the events in multistatus response has 401 status, the batch will be retried with new refresh token for oauth enabled destinations.Related but not dependent - https://github.com/segmentio/integrations/pull/3079
Testing
Testing completed successfully in staging - Test Doc