Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding extra match fields according to LinkedIn Specification. #2676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seg-leonelsanches
Copy link
Contributor

Adding extra match fields according to https://learn.microsoft.com/en-us/linkedin/marketing/matched-audiences/create-and-manage-segment-users?view=li-lms-2024-11&tabs=http#schema.

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.48%. Comparing base (4888857) to head (320a6e2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2676      +/-   ##
==========================================
+ Coverage   78.47%   78.48%   +0.01%     
==========================================
  Files        1032     1032              
  Lines       18590    18601      +11     
  Branches     3521     3526       +5     
==========================================
+ Hits        14588    14599      +11     
  Misses       2825     2825              
  Partials     1177     1177              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joe-ayoub-segment
Copy link
Contributor

Asked @brennan to triage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants