Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mixpanel distinct_id for anonymous events #2684

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nunofgs
Copy link
Contributor

@nunofgs nunofgs commented Jan 16, 2025

This PR adds support for anonymous Mixpanel events by allowing the distinct_id property to be empty, as documented by Mixpanel:

If the event is not associated with any user, set distinct_id to the empty string. Events with an empty distinct_id will be excluded from all behavioral analysis.

Before this PR (when distinct_id is empty):

Screenshot 2025-01-16 at 11 12 42

After this PR:

Screenshot 2025-01-16 at 11 12 58

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@joe-ayoub-segment
Copy link
Contributor

Hi @brennan - this is an external PR for an internally built Destination. Can you triage please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants