Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of create-wrapper.ts #990

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Nov 6, 2023

Some pre-work I did for the consent blocking stuff (using different branch to keep things clean)

  • Refactor out pruned logic into its own file and other misc tweaks.
  • Export "GetCategoriesFunction"

Copy link

changeset-bot bot commented Nov 6, 2023

🦋 Changeset detected

Latest commit: 5faaab0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@segment/analytics-consent-tools Patch
@segment/analytics-consent-wrapper-onetrust Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky changed the title Refactor of consent wrapper Reduce complexity of wrapper.ts Nov 6, 2023
@silesky silesky changed the title Reduce complexity of wrapper.ts Reduce complexity of create-wrapper.ts Nov 6, 2023
@silesky silesky force-pushed the refactor-consent-wrapper branch from c88200a to f369ecd Compare November 6, 2023 23:52
@silesky silesky requested review from oscb and chrisradek November 7, 2023 00:10
@silesky silesky force-pushed the refactor-consent-wrapper branch from f369ecd to 5faaab0 Compare November 7, 2023 00:11
@silesky silesky changed the title Reduce complexity of create-wrapper.ts Reduce size of create-wrapper.ts Nov 7, 2023
@silesky silesky requested a review from bsneed November 7, 2023 16:16
@silesky silesky merged commit a361575 into master Nov 7, 2023
5 checks passed
@silesky silesky deleted the refactor-consent-wrapper branch November 7, 2023 17:36
@github-actions github-actions bot mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants