Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address thread-safety of SCNetworkReachability #295

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Address thread-safety of SCNetworkReachability #295

merged 2 commits into from
Feb 12, 2024

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Feb 12, 2024 •
edited
Loading

  • Added internal ConnectionMonitor singleton.
  • Added 5 minute interval check rather than per event.
  • connectionStatus() checks the monitor for the latest state.
  • Added immediate flag to QueueTimer to allow firing the event at timer creation.
  • Likely will deprecate this field in the future.
  • Fixes Crashing in connectionStatus() on app start #290

@bsneed bsneed merged commit 70490c9 into main Feb 12, 2024
7 checks passed
@bsneed bsneed deleted the bsneed/connectionStatus branch February 12, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanjcharles alanjcharles alanjcharles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crashing in connectionStatus() on app start
2 participants
@bsneed @alanjcharles