apply: Allow ignoring a specific error returned from updatePartitions() #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yolken-segment @cdignam-segment Hey guys. |
|
@hhahn-tw @petedannemann Can you guys please review this one? |
hhahn-tw
requested changes
Mar 21, 2024
shimon-armis
force-pushed
the
shimon.allow_ignoring_error_when_partitions_cnt_conf_smaller_than_the_actual_partitions_cnt
branch
from
f2751c0 to
19daf93
Compare
hhahn-tw
approved these changes
Mar 21, 2024
|
@hhahn-tw Can you please assist with PR check? |
|
@noorul @jkoelker @mericsson @hhahn-tw Can you guys assist with the PR check failure? |
just rebase, it got removed recently: b83ceba |
shimon-armis
force-pushed
the
shimon.allow_ignoring_error_when_partitions_cnt_conf_smaller_than_the_actual_partitions_cnt
branch
from
19daf93 to
cd951e6
Compare
|
@jkoelker can you please approve? |
jkoelker
reviewed
Mar 27, 2024
jkoelker
reviewed
Mar 27, 2024
When applying topic's configuration, we'd like to be able avoid failing in case the desired topic's partition count is smaller than the actual topic's partitions count (on the broker). We know that Kafka doesn't allow partitions decrease, so instead of failing the operation we'd like to continue without doing anything. This is very convenient when trying to apply a batch of topics in which case, we don't want to fail the rest of the batch for one topic that its partition count configuration is lower than the actual partitions count. This change is backward compatible, as the default behavior is kept. Signed-off-by: shimon-armis <[email protected]>
shimon-armis
force-pushed
the
shimon.allow_ignoring_error_when_partitions_cnt_conf_smaller_than_the_actual_partitions_cnt
branch
from
cd951e6 to
6794218
Compare
|
@jkoelker I've addressed the comment and updated the code. Can you please approve? |
|
@yolken-segment @cdignam-segment Can you guys approve? |
jkoelker
approved these changes
Mar 27, 2024
|
@jkoelker Who can merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When applying topic's configuration, we'd like to be able avoid failing in case the desired topic's partitions count is smaller than the actual topic's partitions count (on the broker).
We know that Kafka doesn't allow partitions decrease so instead of failing the operation we'd like to
continue without doing anything (and make this operation idempotent, in that aspect).
This is very convenient when trying to apply a batch of topics in which case, we don't want to fail the rest of the batch for one topic that its partitions count configuration is lower than the actual partitions count. (on the broker).
This change is backward compatible, as the default behavior is kept.