Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring art modules #275

Merged
merged 15 commits into from
Sep 10, 2024
Merged

Refactoring art modules #275

merged 15 commits into from
Sep 10, 2024

Conversation

sadrasabouri
Copy link
Collaborator

What does this implement/fix? Explain your changes.

Added

  • data directory
  • tests directory

Changed

  • art_param module changed to params
  • art module split into errors, utils, and functions modules
  • text_dic1, text_dic2, and text_dic1 renamed to fonts1, fonts2, and fonts3
  • art_dic renamed to arts
  • decor_dic renamed to decorations
  • Fonts, art, and decorations moved to data
  • Tests moved to tests directory

@sadrasabouri sadrasabouri added this to the art 6.3 milestone Aug 5, 2024
@sadrasabouri sadrasabouri self-assigned this Aug 5, 2024
@sadrasabouri sadrasabouri marked this pull request as ready for review August 5, 2024 23:58
sepandhaghighi
sepandhaghighi requested changes Aug 6, 2024
View reviewed changes
Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadrasabouri Thanks for your efforts 🔥
Please review my comments and make sure to update .github/CONTRIBUTING.md

CHANGELOG.md Outdated Show resolved Hide resolved
otherfile/RELEASE.md Show resolved Hide resolved
otherfile/RELEASE.md Show resolved Hide resolved
sepandhaghighi
sepandhaghighi approved these changes Sep 10, 2024
View reviewed changes
Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sepandhaghighi sepandhaghighi merged commit 9ac4048 into dev Sep 10, 2024
44 of 45 checks passed
@sepandhaghighi sepandhaghighi deleted the refactor-modules branch September 10, 2024 10:49
@sepandhaghighi sepandhaghighi mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepandhaghighi sepandhaghighi sepandhaghighi approved these changes

Assignees

@sadrasabouri sadrasabouri

Labels
enhancement major refactor
Projects
None yet
Milestone
art 6.3
Development

Successfully merging this pull request may close these issues.
2 participants
@sadrasabouri @sepandhaghighi