Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/: sget*ent(): Simplify by calling strdup(3) #1146

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

lib/: sget*ent(): Simplify by calling strdup(3) #1146

wants to merge 4 commits into from

Conversation

alejandro-colomar
Copy link
Collaborator

@alejandro-colomar alejandro-colomar commented Dec 7, 2024 •
edited
Loading

While at it, rename the function parameter.

v1b
  • Rebase
$ git range-diff alx/master..gh/strdup_ master..strdup_ 
1:  9b9ee9c8 = 1:  e2169576 lib/: Simplify by calling strdup(3)
2:  b81ed41a = 2:  0d41e7a6 lib/: Remove arbitrary limitation by calling strdup(3)
3:  aab18a17 = 3:  77cf47bb lib/: Rename local variable
4:  a4efdf54 = 4:  0eff731b lib/sgetpwent.c: sgetpwent(): Trim the trailing '\n'

@alejandro-colomar alejandro-colomar force-pushed the strdup_ branch 4 times, most recently from 64c62b1 to b3cf85c Compare December 7, 2024 21:11
@alejandro-colomar alejandro-colomar changed the title lib/sgetgrent.c: sgetgrent(): Simplify by calling strdup(3) lib/: sget*ent(): Simplify by calling strdup(3) Dec 7, 2024
@alejandro-colomar alejandro-colomar mentioned this pull request Dec 9, 2024
Draft
@alejandro-colomar alejandro-colomar marked this pull request as ready for review December 22, 2024 12:05
@alejandro-colomar
lib/: Simplify by calling strdup(3)
e216957 
While at it, rename the function parameter.

Signed-off-by: Alejandro Colomar <[email protected]>
@alejandro-colomar
lib/: Remove arbitrary limitation by calling strdup(3)
0d41e7a 
This makes these APIs more consistent with the ones for groups,
which strdup(3) memory as necessary.

It also makes the code simpler.

Signed-off-by: Alejandro Colomar <[email protected]>
@alejandro-colomar
lib/: Rename local variable
77cf47b 
Call it 'dup', which reminds that it's a strdup(3)d string.

Signed-off-by: Alejandro Colomar <[email protected]>
@alejandro-colomar
lib/sgetpwent.c: sgetpwent(): Trim the trailing '\n'
0eff731 
Just like the other sget*ent() functions do.

Signed-off-by: Alejandro Colomar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallyn hallyn Awaiting requested review from hallyn

@ikerexxe ikerexxe Awaiting requested review from ikerexxe

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alejandro-colomar