Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging contribution from shpingalet007 to allow arguments #4

Closed
wants to merge 9 commits into from

Conversation

shanegenschaw
Copy link
Owner

Merging contributions from @shpingalet007 to allow arguments in PR Khan#34

Changes

  1. Added GitHub Actions input - allow_arguments: Boolean. It enables/disables arguments parsing. It is set to false by default.
  2. Arguments parsing via double-asterisk marker - script looks for ** in trigger and considers the marked part of the comment as argument. Output to the steps.check.outputs.arguments. It doesn't do anything if allow_arguments: false.
  3. Add new example - add job that enables debugging #deploy on ** environment comment.

Other changes

  • Replace npm @zeit/ncc to @vercel/ncc as it was deprecated.
  • Upload new action NCC build.
  • Documented everything in Readme.md.

@shanegenschaw shanegenschaw deleted the comment-args-norebase branch May 26, 2023 16:36
@shanegenschaw shanegenschaw restored the comment-args-norebase branch May 26, 2023 16:37
@shanegenschaw shanegenschaw reopened this May 26, 2023
@shanegenschaw shanegenschaw deleted the comment-args-norebase branch May 26, 2023 16:38
@shanegenschaw shanegenschaw restored the comment-args-norebase branch May 26, 2023 16:38
@shanegenschaw shanegenschaw deleted the comment-args-norebase branch May 26, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants