Repository navigation
Conversation
tmccombs
requested changes
Oct 21, 2026
ump45nose
force-pushed
the
zsh-hidden-aliases
branch
from
October 28, 2026 06:42
a8cb80d to
2b6dbf0
Compare
Upstream already teaches zsh the --dereference / --mindepth / --hyper aliases; keep the reviewer's shorter --hyper form that still offers the auto/never/always values. Signed-off-by: Vincent <1729065730@qq.com>
Contributor
Author
|
Rebased onto current Ready for another look. |
ump45nose
force-pushed
the
zsh-hidden-aliases
branch
from
October 28, 2026 06:42
2b6dbf0 to
8f7022a
Compare
Contributor
Author
|
@tmccombs The two completion suggestions from the changes-requested review are on the current tip ( (AI-assisted reply.) |
Collaborator
|
I don't think this is really necessary given that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The zsh completion omits three option aliases fd actually accepts:
--dereference—alias = "dereference"onfollow(src/cli.rs)--mindepth—alias("mindepth")onmin_depth(src/cli.rs)--hyper—alias = "hyper"onhyperlink(src/cli.rs)The file already handles hidden aliases this way (
!--mount/!--xdevfor--one-file-system,!--newer=/!--older=for the mtime flags, and!(...)--maxdepth:depthfor--max-depth), so the three additions reusethose exact forms:
!--dereferenceinside the(follow)group,!(--exact-depth --min-depth)--mindepth:depthmirroring both the maxdepthentry and the
--min-depthline's own exclusion list, and--hypertakingthe canonical
--hyperlinkspec's value form (=-…::when:(auto never always)).Testing
cargo/zshcould not be executed in the environment I prepared this in,so I am not claiming a completion run: the specs were verified by direct
comparison against the alias definitions in
src/cli.rsat the base commitand the analogous entries already in
_fd.Notes
Two further aliases (
--literalfor--fixed-strings,--has-resultsfor--quiet) are intentionally left out here: their canonical specs aretouched by my open #2176 in the same group, and adding lines at the same
position in two PRs would just create a merge conflict. I plan to follow up
once that lands.
AI assistance disclosure: the omissions were found by an AI-assisted audit
diffing
src/cli.rsalias/option definitions against the completion; Iverified each cited definition and the existing-entry forms in the file
myself before submitting.