[14.0][FIX] shopinvader_product_media: fix active media exclusion #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmequignon
changed the title
simahawk
reviewed
Apr 16, 2024
| } | ||
| ) | ||
|
|
||
| # FIXME |
There was a problem hiding this comment.
FIXME! :)
Eg: do not check for the count but for the right media to be in the list.
simahawk
reviewed
Apr 16, 2024
README.md
Outdated
| @@ -75,7 +75,7 @@ addon | version | maintainers | summary | |||
| [shopinvader_product_brand](shopinvader_product_brand/) | 14.0.1.3.1 | | Shopinvader product Brand | |||
| [shopinvader_product_brand_image](shopinvader_product_brand_image/) | 14.0.1.1.0 | | Shopinvader product Brand Image | |||
| [shopinvader_product_brand_tag](shopinvader_product_brand_tag/) | 14.0.1.0.0 | | Index Product Brand Tags in Shopinvader | |||
| [shopinvader_product_manufactured_for](shopinvader_product_manufactured_for/) | 14.0.1.0.0 | | Manage Product Made Specially For Some Customers | |||
| [shopinvader_product_manufactured_for](shopinvader_product_manufactured_for/) | 14.0.1.1.0 | | Manage Product Made Specially For Some Customers | |||
simahawk
force-pushed
the
14-storage-media-fix-active
branch
from
22aa60a to
fc3438f
Compare
Inactive media should be excluded from exported data. NOTE: this is probably needed on image relations too ;)
mmequignon
force-pushed
the
14-storage-media-fix-active
branch
from
fe2a71e to
72bf132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inactive media should be excluded from exported data.
NOTE: this is probably needed on image relations too ;)