[16.0] [ADD] shopinvader_api_quotation #1573
Conversation
…and add download report
- change behaviour so you can use it without shopinvader context - remove typology in favor of a quotation_state - rework backend UI to make it more human understandable - adapt test
Co-authored-by: David Beal <[email protected]>
Co-authored-by: Laurent Mignon (ACSONE) <[email protected]>
…ref is available on Sale, remove apparent useless available_for_quotation (should be re-added in a separate PR if needed)
There was a problem hiding this comment.
I'm really not a fan of the proposed approach. IMO it's a bad idea to mix quotation and cart into the same concept.... It will lead to the development of some conditional processing on the frontend depending of the type of cart you'll retrieve.
For an ongoing project, I'm currently defining a conceptual approach for an API to handle and manage quotations. The processes involved in managing a quote, and the lifespan of a quote, are very different from that of the shopping cart. Price management for products on quotation can also be different. For commercial reasons, the price will not be displayed on the site and will only be accessible after validation of the quote by a sales representative. The customer may have to modify his quotation or work on it for a long time, without being prevented from placing purchase orders.
🤔
| store=True, | ||
| readonly=False, | ||
| ) | ||
| shop_only_quotation = fields.Boolean(compute="_compute_shop_only_quotation") |
There was a problem hiding this comment.
Only quotation is too restrictive. A product could be only available
- on quotation
- on quotation and direct sale
- on direct sale
Sometimes, you could request a quotation for a set of products in order to get a better price due to the amount total of your order.
| sale = env["shopinvader_api_cart.cart_router.helper"]._request_quotation( | ||
| partner, uuid | ||
| ) |
There was a problem hiding this comment.
IMO a quotation should not be a cart. We should keep the concepts clearly independent since they are not governed by the same workflow. I don't see the point of starting to type the cart. It will introduce breakage in the way you can get your current cart when you want to create a new cart for an immediate purchase while a quotation is pending.
And sale_quotation.
Supersedes #1471
Based on the work of @matthieusaison in #1471 with included requested changes : separate cart router, removal of
customer_refasclient_order_refis already in sale, removal ofavailable_for_quotationas it does nothing in this module, I think another PR should be made for it.