[16.0] [REF] shopinvader_api_cart, shopinvader_api_address: Cart and Address hooks #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paradoxxxzero
changed the title
paradoxxxzero
changed the title
…elper instead of passing the odoo record to the schema method
paradoxxxzero
force-pushed
the
16.0-ref-cart-address-hooks
branch
from
e74a211 to
3088f4f
Compare
lmignon
reviewed
Dec 9, 2024
paradoxxxzero
force-pushed
the
16.0-ref-cart-address-hooks
branch
from
3088f4f to
459f2b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@simahawk, @lmignon Here's a proposal to address #1534 and #1536 in a cleaner way.
I don't think we should promote the use of envs in schema methods, IMO the schema methods should work on the schema data only and the router helpers should work as a joint layer between schemas and models.
This provides the requested hooks in helper classes in the form of the traditional inheritable prepare methods.