Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Twilio and dockerfile (python 3.13-slim) #110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bnjmn
Copy link

@bnjmn bnjmn commented Jan 3, 2025

I've upgraded Twilio and all dependencies in Pipfile. This requires minimum python 3.9 now which I believe is reasonable since 3.8 is EOL.

Here are the current versions that are installed for each package for reference (all tests currently passing on my machine.

(EDIT: See comment below for final versions)

root@b65291349603:/app# pipenv requirements
-i https://pypi.org/simple
aiohappyeyeballs==2.4.4; python_version >= '3.8'
aiohttp==3.11.11; python_version >= '3.9'
aiohttp-retry==2.8.3; python_version >= '3.7'
aiosignal==1.3.2; python_version >= '3.9'
attrs==24.3.0; python_version >= '3.8'
certifi==2024.12.14; python_version >= '3.6'
charset-normalizer==3.4.1; python_version >= '3.7'
frozenlist==1.5.0; python_version >= '3.8'
idna==3.10; python_version >= '3.6'
multidict==6.1.0; python_version >= '3.8'
propcache==0.2.1; python_version >= '3.9'
pyjwt==2.10.1; python_version >= '3.9'
pytz==2024.2
requests==2.32.3; python_version >= '3.8'
-e . ; python_version >= '3.6'
six==1.17.0; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2'
twilio==9.4.1; python_full_version >= '3.7.0'
urllib3==2.3.0; python_version >= '3.9'
yarl==1.18.3; python_version >= '3.9'

Related to #85 – I tried python 3.13 and 3.12 but would also need to install gcc
Duplicates #95
Closes #78

I suggest merging this and making a new 3.0 (or 2.2.0) release of SignalWire Python SDK if possible. That would be great; Thanks!

Bumps dockerfile to python:3.13-slim
@bnjmn bnjmn changed the title Upgrade Twilio and dockerfile (python 3.11-slim) WIP Upgrade Twilio and dockerfile (python 3.13-slim) Jan 3, 2025
@bnjmn bnjmn marked this pull request as draft January 3, 2025 17:42
Fax module was removed in Twilio 7.6.0 so pinning it before that.
@bnjmn
Copy link
Author

bnjmn commented Jan 3, 2025

Ran into some issues due to twilio having removed their support for Fax in version 7.6.0

Current dependencies for reference are now:

root@4f4a07cb12a6:/app# pipenv requirements
-i https://pypi.org/simple
aiohappyeyeballs==2.4.4; python_version >= '3.8'
aiohttp==3.11.11; python_version >= '3.9'
aiosignal==1.3.2; python_version >= '3.9'
attrs==24.3.0; python_version >= '3.8'
certifi==2024.12.14; python_version >= '3.6'
charset-normalizer==3.4.1; python_version >= '3.7'
frozenlist==1.5.0; python_version >= '3.8'
idna==3.10; python_version >= '3.6'
multidict==6.1.0; python_version >= '3.8'
propcache==0.2.1; python_version >= '3.9'
pyjwt==2.10.1; python_version >= '3.9'
pytz==2024.2
requests==2.32.3; python_version >= '3.8'
-e . ; python_version >= '3.6'
six==1.17.0; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2'
twilio==7.5.1; python_full_version >= '3.6.0'
urllib3==2.3.0; python_version >= '3.9'
yarl==1.18.3; python_version >= '3.9'

@bnjmn bnjmn changed the title WIP Upgrade Twilio and dockerfile (python 3.13-slim) Upgrade Twilio and dockerfile (python 3.13-slim) Jan 3, 2025
@bnjmn bnjmn marked this pull request as ready for review January 3, 2025 18:05
@bnjmn
Copy link
Author

bnjmn commented Jan 3, 2025

@jpsantosbh Hello! Can you take a look at this when you have a chance? Should be ready to merge at this point as far as I can tell but let me know if you need anything else; all tests are passing for me locally right now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency issue with using an older version of Twilio library
1 participant