feat(gossipsub): Remove peer_topics and topic_peers #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
force-pushed
the
remove-peer-topics-topic-peers
branch
6 times, most recently
from
9a3dcf8 to
5f43d26
Compare
AgeManning
reviewed
Jan 9, 2024
protocols/gossipsub/src/metrics.rs
Outdated
| /// The size of the priority queue. | ||
| priority_queue_size: Histogram, | ||
| /// The size of the priority queue for each PeerId. | ||
| priority_queue_size: Family<PeerIdLabel, Histogram, HistBuilder>, |
There was a problem hiding this comment.
If we do this, doesn't this grow unbounded. Like PeerId's come and go. And we have no way to remove them from the mappings?
There was a problem hiding this comment.
This metric was for debugging purposes more than anything. Can be removed now i think
jxs
force-pushed
the
remove-peer-topics-topic-peers
branch
from
5f43d26 to
eaaee16
Compare
jxs
force-pushed
the
remove-peer-topics-topic-peers
branch
3 times, most recently
from
77c59a2 to
ae9f94c
Compare
jxs
force-pushed
the
remove-peer-topics-topic-peers
branch
from
ae9f94c to
0d3ceaf
Compare
AgeManning
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use only the
connectec_peersmapping