Repository navigation
Remove reset logic - #1950
Remove reset logic#1950woodruffw wants to merge 1 commit into
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
|
Manual dispatch from this ref: https://github.com/sigstore/sigstore-python/actions/runs/39447844562 |
|
Clanker analysis: It was a workaround for how peter-evans/create-pull-request handled changes already committed by an earlier job. PR #572 introduced the “generate → test → open PR” sequence. The PR job checked out the tested commit, then reset only the remote branch to main, leaving the local commit intact. The old action could then detect that local commit as an unpublished change and push it again before opening the PR. Without that reset, its branch-processing logic could discard the already-published change when reconstructing the PR branch. That rationale is inferred from the action’s implementation; the original PR doesn’t explain the reset explicitly. PR #1625 replaced the action with gh pr create but retained the reset. Since gh pr create --head … doesn’t push local commits, nothing restores the remote branch afterward. So it became obsolete during that migration, and removing it is the appropriate fix. |
This was blocking the requirements pins updates. I don't fully understand what it was originally added for (can't remember).