Skip to content

Remove reset logic - #1950

Open
woodruffw wants to merge 1 commit into
mainfrom
ww/fix-pin-requirements-pr
Open

woodruffw wants to merge 1 commit into
mainfrom
ww/fix-pin-requirements-pr

Conversation

@woodruffw

Copy link
Copy Markdown
Member

This was blocking the requirements pins updates. I don't fully understand what it was originally added for (can't remember).

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw

Copy link
Copy Markdown
Member Author

Manual dispatch from this ref: https://github.com/sigstore/sigstore-python/actions/runs/39447844562

@woodruffw

Copy link
Copy Markdown
Member Author

#1951

@woodruffw

Copy link
Copy Markdown
Member Author

Clanker analysis:

It was a workaround for how peter-evans/create-pull-request handled changes already committed by an earlier job.

PR #572 introduced the “generate → test → open PR” sequence. The PR job checked out the tested commit, then reset only the remote branch to main, leaving the local commit intact. The old action could then detect that local commit as an unpublished change and push it again before opening the PR. Without that reset, its branch-processing logic could discard the already-published change when reconstructing the PR branch. That rationale is inferred from the action’s implementation; the original PR doesn’t explain the reset explicitly.

PR #1625 replaced the action with gh pr create but retained the reset. Since gh pr create --head … doesn’t push local commits, nothing restores the remote branch afterward.

So it became obsolete during that migration, and removing it is the appropriate fix.

@woodruffw
woodruffw requested a review from jku October 20, 2026 15:35
@woodruffw woodruffw self-assigned this Oct 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant