Skip to content

fix(magnetic sensor spi): the data mask must not be a static local #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stijncarelsbergh wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(magnetic sensor spi): the data mask must not be a static local #578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sensors/MagneticSensorSPI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ word MagneticSensorSPI::read(word angle_register){

register_value = register_value >> (1 + data_start_bit - bit_resolution); //this should shift data to the rightmost bits of the word

const static word data_mask = 0xFFFF >> (16 - bit_resolution);
const word data_mask = 0xFFFF >> (16 - bit_resolution);

return register_value & data_mask; // Return the data, stripping the non data (e.g parity) bits
}
Expand Down