Skip to content

fix(magnetic sensor i2c): mask and shift the left-aligned LSB bits correctly #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stijncarelsbergh wants to merge 1 commit into
base: dev
Choose a base branch
from
+7 −3
Open

fix(magnetic sensor i2c): mask and shift the left-aligned LSB bits correctly #579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/sensors/MagneticSensorI2C.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,15 @@ MagneticSensorI2C::MagneticSensorI2C(uint8_t _chip_address, int _bit_resolution,
_conf.msb_mask = (uint8_t)( (1 << _bits_used_msb) - 1 );

uint8_t lsb_used = _bit_resolution - _bits_used_msb; // used bits in LSB
_conf.lsb_mask = (uint8_t)( (1 << (lsb_used)) - 1 );
if (!lsb_right_aligned)
if (!lsb_right_aligned){
// left aligned: the remaining bits are in the upper part of the low byte,
// e.g. 6 bits -> 0xFC, read with >> 2
_conf.lsb_mask = (uint8_t)( ((1 << (lsb_used)) - 1) << (8 - lsb_used) );
_conf.lsb_shift = 8-lsb_used;
else
}else{
_conf.lsb_mask = (uint8_t)( (1 << (lsb_used)) - 1 );
_conf.lsb_shift = 0;
}
_conf.msb_shift = lsb_used;

cpr = _powtwo(_bit_resolution);
Expand Down