Skip to content

[upstream cleanup candidate] Jenkinsfile: deduplicate recordIssues/checkout stages and refresh 2018-2021 toolchain pins #6

Open

Description

@sims1253

Curation review — 2026-09-06

Jenkins migration already delivered. The main Jenkins migration is implemented by stan-dev#1344. The remaining preparation scope is the Python test-runner/toolchain cleanup identified in the source review. Keep that residual scope separate from completed upstream work; the original Jenkins-stage proposal no longer describes the current tree.

Original proposal and historical evidence (predates this review)

The Jenkinsfile carries 2018-2021 settings and copy-paste:

  • Jenkinsfile:176-193, :217-234, :250-267 — three near-identical 18-line recordIssues blocks differing only in id/name; collapse into one Groovy function taking a label
  • Jenkinsfile:59 — LINUX_CXX = 'clang++-6.0' (2018)
  • Jenkinsfile:21-27 — Windows PATH hardcodes RTOOLS40_HOME, LLVM7, R-4.1.2, jenkins\Anaconda3
  • Jenkinsfile:89-110 — "Verify changes" repeats the full checkout scm + git clean -xffd of "Clean & Setup" (:69-88)
  • the auto-format bot commits with clang-format 10 (2020) — upgrading reformats thousands of lines, so pin/upgrade deliberately
  • runCmdStanTests.py — #!/usr/bin/python shebang, j == None, %-formatting, hand-rolled batching (:1,66,100-112)

Present in stan-dev/cmdstan develop @ f8f54c5 (2026-08-27).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions