Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed drawing while brush outside #157

Merged
merged 1 commit into from
May 18, 2024
Merged

Fixed drawing while brush outside #157

merged 1 commit into from
May 18, 2024

Conversation

The-Phoenics
Copy link
Contributor

@The-Phoenics The-Phoenics commented May 18, 2024

Issue Title: Now can draw while the brush is outside of canvas

resolve issue: #80

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

How Has This Been Tested? ⚙️

Describe how have you verified the changes made.

Fix verification :

drawitout.mp4

Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
draw-it-out ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 8:38am
draw-it-out-zbd1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 8:38am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

Copy link
Collaborator

@0xabdulkhaliq 0xabdulkhaliq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👀

@0xabdulkhaliq 0xabdulkhaliq added bug Something isn't working gssoc level1 labels May 18, 2024
@singodiyashubham87 singodiyashubham87 merged commit 014a61b into singodiyashubham87:main May 18, 2024
5 checks passed
@singodiyashubham87
Copy link
Owner

@The-Phoenics Thanks for contributing, Keep it up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants