Repository navigation
fix(gui): describe deobfuscation whitelist as space separated in tooltip - #3030
Merged
Merged
Conversation
The whitelist string is split on spaces (JadxCLIArgs.toJadxArgs), and the CLI help already says "space separated", but the GUI tooltip still said ':' separated, from before the separator was changed.
protonnegativo
force-pushed
the
fix/deobf-whitelist-tooltip
branch
from
October 24, 2026 03:35
ca37542 to
8f28885
Compare
protonnegativo
marked this pull request as ready for review
October 24, 2026 03:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗ Please review the guidelines for contributing
Description
The tooltip for "Exclude packages and classes from deobfuscation" says the list is
':'separated, but the value is split on spaces:JadxCLIArgs.toJadxArgs():args.setDeobfuscationWhitelist(Arrays.asList(deobfuscationWhitelistStr.split(" ")));. The GUI goes through the same method (JadxSettings.toJadxArgs()->JadxSettingsData extends JadxGUIArgs extends JadxCLIArgs).DeobfWhitelist.DEFAULT_STR = Utils.listToString(DEFAULT_LIST, " "), so the edit dialog already shows the default entries separated by spaces.--deobf-whitelisthelp: "space separated list of classes (full name) and packages (ends with '.*') ...".The
':'wording dates from #2040; the separator was changed to a space in the follow-up refactor (a989fa7), and the tooltip was not updated. A user who follows the tooltip and entersa.b.*:c.Dgets one entry, whichDeobfWhitelist.init()treats as a class name (it doesn't end with.*), so neither the package nor the class is excluded.Changes, all on line 328 of the i18n files:
en_US:':' separated->space separated.es_ES,id_ID,ko_KR,pt_BR: the commented copy of the English text updated to match.The translated tooltips (
de_DE,ru_RU,zh_CN,zh_TW) still mention':'; I left them for translators rather than guess the wording.Tested:
./gradlew :jadx-gui:test --tests 'jadx.gui.TestI18n'and./gradlew spotlessCheckpass. The full./gradlew clean build distwasn't run locally; the change is text-only in.propertiesfiles.