-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Wayland improvements #338
base: master
Are you sure you want to change the base?
Conversation
If X11 Display constructor raises an error, then the screen is Wayland only, update the context.
Hi, |
sway is running on my machine and the Xorg layer (called xwayland) is not enabled. Therefore the Display object creations fails because it cannot find the X display name (since there isn't any):
|
I see. Please let me know once the PR is completed. |
Any progress on this? |
This PR seems abandoned ? Any news ? |
Unfortunately I haven't had time to work on this. Please, feel free to pick-it up from where I have left it. |
I've looked into pywayland, and as far as I can tell this is a dead-end (because you can't grab the wl_surface from Gtk to pass to pywayland), the real way to do this is to update to GTK/GDK4 and use their abstraction over the wayland protocol (which I assume should also work on X). |
In my gtk4 port #561, I address this by using inhibit_system_shortcuts on wayland. |
The disadvantage of this PR is that the keyboard will not be blocked when Wayland is used.
The protocol for inhibiting the keyboard should be used as swaylock does, but it requires more work.
I should look more into pywayland for adding this feature.
No exceptions are raised so far, and the window get closed without problems. but I haven't understood the "Lock Screen" button so I am not sure if it works (probably not).