smartpause: use swayidle on all non-gnome wayland sessions #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC #391.
swayidle by default now uses the standardized ext-idle-notify-v1 protocol, so in theory this should be supportable by all wayland compositors in the future. Notably, gnome does not support it, so keep using the gnome-specific solution in that case.
Tested on KDE Plasma 5.27 Wayland.
This should possibly still be tested on a non-gnome compositor without ext-idle-notify support, with swayidle installed, as this PR will make that case go from using xprintidle to probably failing not that gracefully. However, xprintidle on wayland compositors was pretty much broken already.
According to this, this would be something using weston or mir - however, those tend to be pretty niche, and since this un-breaks smartpause on KDE Plasma, this might be more important.