Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2 #15

Merged
merged 43 commits into from
Sep 9, 2024
Merged

Issue 2 #15

merged 43 commits into from
Sep 9, 2024

Conversation

Nathmel123
Copy link
Collaborator

Implemented mei-xml conversion.

@Nathmel123 Nathmel123 requested a review from dikastes March 27, 2024 13:20
Copy link
Collaborator

@dikastes dikastes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great result, some minor formatting issues and I have some small and two big desires concerning styling.

Classes/Common/XmlDocument.php Outdated Show resolved Hide resolved
Classes/Common/XmlDocument.php Outdated Show resolved Hide resolved
Classes/Common/XmlDocument.php Outdated Show resolved Hide resolved
Classes/Common/XmlDocument.php Outdated Show resolved Hide resolved
Classes/Common/XmlDocument.php Outdated Show resolved Hide resolved
Classes/Common/XmlDocument.php Show resolved Hide resolved
Classes/Common/XmlDocument.php Show resolved Hide resolved
Classes/Common/XmlDocument.php Outdated Show resolved Hide resolved
Classes/Common/XmlDocument.php Show resolved Hide resolved
Classes/Common/XmlDocument.php Show resolved Hide resolved
@Nathmel123 Nathmel123 requested a review from dikastes May 2, 2024 09:26
@Nathmel123 Nathmel123 removed the request for review from dikastes May 15, 2024 13:21
@Nathmel123 Nathmel123 requested a review from dikastes July 4, 2024 06:44
@dikastes dikastes changed the base branch from main to dev July 4, 2024 08:52
Classes/Common/XmlDocument.php Outdated Show resolved Hide resolved
Tests/Unit/Common/XmlDocumentTest.php Outdated Show resolved Hide resolved
Classes/Common/XmlDocument.php Show resolved Hide resolved
Classes/Common/XmlDocument.php Show resolved Hide resolved
Classes/Common/XmlDocument.php Outdated Show resolved Hide resolved
Tests/Unit/Common/XmlDocumentTest.php Show resolved Hide resolved
@Nathmel123 Nathmel123 self-assigned this Jul 11, 2024
@Nathmel123 Nathmel123 requested a review from dikastes September 3, 2024 09:28
@Nathmel123
Copy link
Collaborator Author

Nathmel123 commented Sep 5, 2024

Somehow composer does not run properly at my machine, if I merge dev into issue-2 and then pull.

@Nathmel123
Copy link
Collaborator Author

Fixed

@dikastes dikastes merged commit 4758559 into dev Sep 9, 2024
3 checks passed
@dikastes dikastes deleted the issue-2 branch September 9, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants