Top-level reading order #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e attributes (but not @Custom); ensure readingorder idrefs are correct (also for dummy text and image region)
- `TextractLayout`: init with additional list
of top-level block dict stored in `child_regions`:
- just ID→dict (for LAYOUT_ types during build)
- or ID→block (for TextractTable, KEY, SELECTION etc.
already instantiated)
- add `parent_layout` reference
- `TextractTable`: add `parent_layout` reference
- `TextractKey`: add `parent_layout` reference
- `TextractValue`: add `parent_layout` reference
- build `layouts` after all other blocks are built
- replace recursive `child_regions` / `parent_layout`
after all `layouts` are built; remove recursive
instances from top level to avoid duplication
in ReadingOrder or PcGts instantiation
- ReadingOrder: extend recursive case (OrderedGroup)
of `LAYOUT_FIGURE` with `LINE` children to `LAYOUT_*`
with any `child_regions`
- instantiation of PcGts types for `layouts`
and `tables`: refactor as (inline) function
for recursion and
- try to re-use code
- add assertions around known types of recursion
(to be revisited with better documentation from AWS
or more data examples)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental. Details follow...