Add I/O-safe traits #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on how the standard library implements them, if we cannot provide the same behavior, I prefer not to do this since we are not providing the same API anyway. |
18 tasks
|
Can we just bump up the major version with the latest MSRV? |
|
Rewritten to use |
|
Published in 1.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new feature,
io_safety, which requires Rust 1.63. With this feature, the types in this crate implementAsFd/AsSocketandTryFrom<OwnedFd/OwnedSocket>.See also: sunfishcode/io-lifetimes#38
Should I also implement
TryInto<OwnedFd/OwnedSocket>on these types? It would involve unwrapping theArc, which doesn't feel idiomatic, but it would complete the symmetry withstd.