merge samples in kallisto_quant step #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The implementation is fine. I am just wondering if this is really what one wants to do. If units are just unmerged lanes, then yes. If they are technical replicates, then probably no. Let us have a chat about this when I am in the office on Thursday. |
|
Sure, let's discuss further. My first instinct would be for technical replicates to be modelled via the batch variables... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements sample merging by providing kallisto with all the units of a sample at once. I.e. if multiple sequencing runs are provided for a sample as units, kallisto will jointly quantify abundance for all the runs. In addition, the workflow now checks whether units of a sample are either all paired end or all single end and throws an exception if this is violated for a sample.