Skip to content

Add missing adapter require to server. - #84

Merged
ioquatix merged 1 commit into
socketry:mainfrom
wtn:require
Oct 21, 2026
Merged

ioquatix merged 1 commit into
socketry:mainfrom
wtn:require

Conversation

@wtn

@wtn wtn commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

server.rb doesn't require adapters/http:

% ruby -I lib -e 'require "async/websocket"; require "protocol/http/request"
  Async::WebSocket::Server.new(->(r){}).call(Protocol::HTTP::Request["GET", "/"])' 

../async-websocket/lib/async/websocket/server.rb:25:in 'Async::WebSocket::Server#call': uninitialized constant Async::WebSocket::Adapters (NameError)

				Async::WebSocket::Adapters::HTTP.open(request, **@options, &@block) or super
				                ^^^^^^^^^^
	from -e:2:in '<main>'

Types of Changes

  • Bug fix.
  • Maintenance.

Contribution

@ioquatix
ioquatix marked this pull request as ready for review October 21, 2026 06:10
@ioquatix
ioquatix merged commit 8a89ed3 into socketry:main Oct 21, 2026
16 of 20 checks passed
@ioquatix

Copy link
Copy Markdown
Member

Thanks!

@wtn
wtn deleted the require branch October 21, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants