Run LLVM sanitizers on CI

Signed-off-by: Juan Cruz Viotti <[email protected]>
sourcemeta · Feb 9, 2024 · 377fcd7 · 377fcd7
1 parent e7e5c06
commit 377fcd7
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -25,7 +25,18 @@ jobs:
             # cc: gcc
             # cxx: g++
           - os: windows-latest
-          # TODO: Enable sanitizers
+
+          # Sanitizers
+          - os: ubuntu-latest
+            cc: clang
+            cxx: clang++
+            type: static
+            options: -DJSONBINPACK_ADDRESS_SANITIZER:BOOL=ON
+          - os: ubuntu-latest
+            cc: clang
+            cxx: clang++
+            type: static
+            options: -DJSONBINPACK_UNDEFINED_SANITIZER:BOOL=ON
 
     runs-on: ${{ matrix.platform.os }}
     env:
@@ -64,6 +75,7 @@ jobs:
           -DJSONBINPACK_DOCS:BOOL=OFF
           -DBUILD_SHARED_LIBS:BOOL=OFF
           -DCMAKE_COMPILE_WARNING_AS_ERROR:BOOL=ON
+          ${{ matrix.platform.options }}
       - run: cmake --build ./build --config Release --target clang_format_test
       - run: cmake --build ./build --config Release --parallel 4
       - run: >

diff --git a/src/runtime/include/sourcemeta/jsonbinpack/runtime_varint.h b/src/runtime/include/sourcemeta/jsonbinpack/runtime_varint.h
@@ -19,12 +19,12 @@ auto varint_encode(std::basic_ostream<CharT, Traits> &stream,
   std::uint64_t accumulator = value;
 
   while (accumulator > LEAST_SIGNIFICANT_BITS) {
-    stream.put(static_cast<std::uint8_t>(
-        (accumulator & LEAST_SIGNIFICANT_BITS) | MOST_SIGNIFICANT_BIT));
+    stream.put(static_cast<CharT>((accumulator & LEAST_SIGNIFICANT_BITS) |
+                                  MOST_SIGNIFICANT_BIT));
     accumulator >>= SHIFT;
   }
 
-  stream.put(static_cast<std::uint8_t>(accumulator));
+  stream.put(static_cast<CharT>(accumulator));
   return stream;
 }
 

diff --git a/src/runtime/include/sourcemeta/jsonbinpack/runtime_zigzag.h b/src/runtime/include/sourcemeta/jsonbinpack/runtime_zigzag.h
@@ -12,7 +12,7 @@ constexpr auto zigzag_encode(const std::int64_t value) noexcept
     return value * 2;
   }
 
-  return (std::abs(value) * 2) - 1;
+  return (static_cast<std::uint64_t>(std::abs(value)) * 2) - 1;
 }
 
 constexpr auto zigzag_decode(const std::uint64_t value) noexcept