Enable sanitizers with Noa

.github/workflows/ci.yml

@@ -25,7 +25,18 @@ jobs:
             # cc: gcc
             # cxx: g++
           - os: windows-latest
-          # TODO: Enable sanitizers
+
+          # Sanitizers
+          - os: ubuntu-latest
+            cc: clang
+            cxx: clang++
+            type: static
+            options: -DJSONBINPACK_ADDRESS_SANITIZER:BOOL=ON
+          - os: ubuntu-latest
+            cc: clang
+            cxx: clang++
+            type: static
+            options: -DJSONBINPACK_UNDEFINED_SANITIZER:BOOL=ON
 
     runs-on: ${{ matrix.platform.os }}
     env:
@@ -64,6 +75,7 @@ jobs:
           -DJSONBINPACK_DOCS:BOOL=OFF
           -DBUILD_SHARED_LIBS:BOOL=OFF
           -DCMAKE_COMPILE_WARNING_AS_ERROR:BOOL=ON
+          ${{ matrix.platform.options }}
       - run: cmake --build ./build --config Release --target clang_format_test
       - run: cmake --build ./build --config Release --parallel 4
       - run: >

src/runtime/include/sourcemeta/jsonbinpack/runtime_decoder.h

@@ -130,19 +130,21 @@ class Decoder : private BasicDecoder<CharT, Traits> {
       // We trust the encoder that the data we are seeing
       // corresponds to a valid 64-bit signed integer.
       return sourcemeta::jsontoolkit::JSON{static_cast<std::int64_t>(
-          -(static_cast<std::int64_t>(this->get_varint() *
-                                      options.multiplier)) +
-          closest_maximum_multiple)};
+          -(static_cast<std::int64_t>(
+              this->get_varint() *
+              static_cast<std::int64_t>(options.multiplier))) +
+          static_cast<std::int64_t>(closest_maximum_multiple))};
     } else {
       const std::uint64_t closest_maximum_multiple{
           static_cast<std::uint32_t>(std::abs(closest_maximum)) *
           options.multiplier};
       // We trust the encoder that the data we are seeing
       // corresponds to a valid 64-bit signed integer.
       return sourcemeta::jsontoolkit::JSON{static_cast<std::int64_t>(
-          -(static_cast<std::int64_t>(this->get_varint() *
-                                      options.multiplier)) -
-          closest_maximum_multiple)};
+          -(static_cast<std::int64_t>(
+              this->get_varint() *
+              static_cast<std::int64_t>(options.multiplier))) -
+          static_cast<std::int64_t>(closest_maximum_multiple))};
     }
   }
 
@@ -153,7 +155,8 @@ class Decoder : private BasicDecoder<CharT, Traits> {
     // We trust the encoder that the data we are seeing
     // corresponds to a valid 64-bit signed integer.
     return sourcemeta::jsontoolkit::JSON{static_cast<std::int64_t>(
-        this->get_varint_zigzag() * options.multiplier)};
+        this->get_varint_zigzag() *
+        static_cast<std::int64_t>(options.multiplier))};
   }
 
   /// @}

src/runtime/include/sourcemeta/jsonbinpack/runtime_decoder_basic.h

@@ -80,7 +80,7 @@ template <typename CharT, typename Traits> class BasicDecoder {
     result.reserve(length);
     std::uint64_t counter = 0;
     while (counter < length) {
-      result += this->get_byte();
+      result += static_cast<CharT>(this->get_byte());
       counter += 1;
     }
 

src/runtime/include/sourcemeta/jsonbinpack/runtime_encoder.h

@@ -86,7 +86,8 @@ class Encoder : private BasicEncoder<CharT, Traits> {
 #endif
     assert(is_byte(enum_maximum - enum_minimum));
     this->put_byte(static_cast<std::uint8_t>(
-        static_cast<std::int64_t>(value / options.multiplier) - enum_minimum));
+        (value / static_cast<std::int64_t>(options.multiplier)) -
+        enum_minimum));
   }
 
   auto FLOOR_MULTIPLE_ENUM_VARINT(const sourcemeta::jsontoolkit::JSON &document,
@@ -128,7 +129,8 @@ class Encoder : private BasicEncoder<CharT, Traits> {
     const std::int64_t value{document.to_integer()};
     assert(options.multiplier > 0);
     assert(std::abs(value) % options.multiplier == 0);
-    this->put_varint_zigzag(value / options.multiplier);
+    this->put_varint_zigzag(value /
+                            static_cast<std::int64_t>(options.multiplier));
   }
 
   /// @}