spinapp: Relax executor validation #308
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been using the Spin Operator with Flux deployments, and requring executors to exist before creating a Spin App leads to some... rather un-ergonomic requirements, by nature of how resource installations need to be tiered when orchestrating tools like Flux: Specifically: 1) Install dependencies (cert-manager) 2) Install Spin Operator 3) Install executor 4) finally install application This seems reasonable enough at first, but because executors and applications are in the same domain (namespace), it's more awkward than one would otherwise expect, because every application suddenly becomes _two_ sets of packages rather than one. By relaxing this requirement, we still provide feedback to users (events), but allow those to be collapsed back into a single installation step - which is a great improvement for the simplest-possible case.
| @@ -33,45 +16,3 @@ func TestValidateReplicas(t *testing.T) { | |||
| fldErr = validateReplicas(spinv1alpha1.SpinAppSpec{Replicas: 1}) | |||
| require.Nil(t, fldErr) | |||
| } | |||
|
|
|||
| func TestValidateAnnotations(t *testing.T) { | |||
There was a problem hiding this comment.
How come we're getting rid of these?
There was a problem hiding this comment.
They only make sense in the context of an executor right now - which when it's not necessarily there already, would cause inconsistent validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using the Spin Operator with Flux deployments, and requring executors to exist before creating a Spin App leads to some... rather un-ergonomic requirements, by nature of how resource installations need to be tiered when orchestrating tools like Flux:
Specifically:
This seems reasonable enough at first, but because executors and applications are in the same domain (namespace), it's more awkward than one would otherwise expect, because every application suddenly becomes two sets of packages rather than one.
By relaxing this requirement, we still provide feedback to users (events), but allow those to be collapsed back into a single installation step - which is a great improvement for the simplest-possible case.