add more types

Signed-off-by: Viktor Tsvetkov <[email protected]>
splunk · Jan 9, 2025 · fac69fe · fac69fe
1 parent 8eac413
commit fac69fe
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/ui/package.json b/ui/package.json
@@ -1,12 +1,12 @@
 {
   "name": "@splunk/add-on-ucc-framework",
-  "description": "Splunk Add-on SDK formerly UCC is a build and code generation framework",
+  "description": "UCC is a build and code generation framework for building Splunk Add-ons (TAs)",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/splunk/addonfactory-ucc-generator.git",
     "directory": "ui"
   },
-  "version": "5.55.0",
+  "version": "5.56.0",
   "license": "Apache-2.0",
   "author": "Splunk Inc.",
   "homepage": "https://splunk.github.io/addonfactory-ucc-generator",

diff --git a/ui/src/components/CustomTab/CustomTab.tsx b/ui/src/components/CustomTab/CustomTab.tsx
@@ -1,12 +1,9 @@
 import React, { useEffect, useRef, useState } from 'react';
 import { _ } from '@splunk/ui-utils/i18n';
-import { z } from 'zod';
 import { getUnifiedConfigs } from '../../util/util';
 import { getBuildDirPath } from '../../util/script';
-import { TabSchema } from '../../types/globalConfig/pages';
 import { CustomTabConstructor } from './CustomTabBase';
-
-type Tab = z.infer<typeof TabSchema>;
+import { Tab } from './CustomTab.types';
 
 interface CustomTabProps {
     tab: Tab;

diff --git a/ui/src/components/CustomTab/CustomTab.types.ts b/ui/src/components/CustomTab/CustomTab.types.ts
@@ -0,0 +1,4 @@
+import { z } from 'zod';
+import { TabSchema } from '../../types/globalConfig/pages';
+
+export type Tab = z.infer<typeof TabSchema>;
diff --git a/ui/src/components/CustomTab/CustomTabBase.ts b/ui/src/components/CustomTab/CustomTabBase.ts
@@ -1,3 +1,5 @@
+import { Tab } from './CustomTab.types';
+
 export type CustomTabInstance<T extends typeof CustomTabBase = typeof CustomTabBase> =
     InstanceType<T>;
 
@@ -6,11 +8,11 @@ export type CustomTabConstructor<T extends typeof CustomTabBase = typeof CustomT
 ) => CustomTabInstance<T>;
 
 export abstract class CustomTabBase {
-    protected tab: object;
+    protected tab: Tab;
 
-    protected el: HTMLElement;
+    protected el: HTMLDivElement;
 
-    constructor(tab: object, el: HTMLElement) {
+    constructor(tab: Tab, el: HTMLDivElement) {
         this.tab = tab;
         this.el = el;
     }