Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt to address #114
Two issues to resolve
zip.setUtf8Enabled
needs to be called beforeQuaZip::open
to have any effect. Some JlCompress methods haveQuaZip* zip
as an input so passing a different Option there makes no difference. It could confuse someone who would expect this to be set either way, not the best API..Current integration tests do not really seem to test UTF-8 support (at least on Linux). Whether UTF-8 is enabled or not, the tests pass (see for example
TestQuaZipFile::zipUnzip()
, changing the flag makes no difference). Need to investigate why that is and test for negative example.