Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(astro): allow URLs in meta.image #422

Merged
merged 2 commits into from
Nov 25, 2024
Merged

fix(astro): allow URLs in meta.image #422

merged 2 commits into from
Nov 25, 2024

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Nov 20, 2024 •
edited
Loading

  • Using URL in meta.image should work

AriPerkkio/tutorial-vite-plugin#29

@stackblitz StackBlitz
Copy link

stackblitz bot commented Nov 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@AriPerkkio AriPerkkio changed the title fix(astro): URLs in meta.image fix(astro): allow URLs in meta.image Nov 20, 2024
@AriPerkkio

This comment was marked as outdated.

Sign in to view
@AriPerkkio AriPerkkio mentioned this pull request Nov 20, 2024
Closed
@AriPerkkio

This comment was marked as outdated.

Sign in to view
@AriPerkkio AriPerkkio force-pushed the fix/default-og-image branch 2 times, most recently from 3fa58bf to 2f931e0 Compare November 25, 2024 09:03
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 25, 2024 •
edited
Loading

Open in Stackblitz

@tutorialkit/astro

npm i https://pkg.pr.new/@tutorialkit/astro@422

@tutorialkit/react

npm i https://pkg.pr.new/@tutorialkit/react@422

@tutorialkit/runtime

npm i https://pkg.pr.new/@tutorialkit/runtime@422

@tutorialkit/theme

npm i https://pkg.pr.new/@tutorialkit/theme@422

@tutorialkit/types

npm i https://pkg.pr.new/@tutorialkit/types@422

commit: e61cb26

@AriPerkkio AriPerkkio mentioned this pull request Nov 25, 2024
Closed
@AriPerkkio AriPerkkio merged commit 3125547 into stackblitz:main Nov 25, 2024
13 checks passed
@AriPerkkio AriPerkkio deleted the fix/default-og-image branch November 25, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-burel eric-burel eric-burel left review comments

Assignees
No one assigned
Labels
pkg-pr-new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AriPerkkio @eric-burel