Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use only native caches from actions/setup-go and golangci/golangci-lint-action #875

Closed
wants to merge 1 commit into from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Dec 2, 2024

Those two steps are not of use anymore as caches are alredy handle by actions

  • actions/setup-go@v5
    • ~/.cache/go-build
    • ~/go/pkg/mod
  • golangci/golangci-lint-action@v6
    • ~/.cache/golangci-lint

@mmorel-35 mmorel-35 requested a review from rhybrillou as a code owner December 2, 2024 10:35
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.89%. Comparing base (dbd7529) to head (44b268f).
Report is 68 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
- Coverage   62.36%   58.89%   -3.47%     
==========================================
  Files         197      199       +2     
  Lines        4854     5790     +936     
==========================================
+ Hits         3027     3410     +383     
- Misses       1439     1988     +549     
- Partials      388      392       +4     
Flag Coverage Δ
unit 58.89% <ø> (-3.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 changed the title chore: use only native caches from actions/setup-go chore: use only native caches from actions/setup-go and golangci/golangci-lint-action Dec 2, 2024
@mmorel-35
Copy link
Contributor Author

/cc @rhybrillou

@janisz janisz self-assigned this Jan 13, 2025
@janisz janisz self-requested a review January 13, 2025 16:36
Copy link
Collaborator

@janisz janisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is reasonable, but we've previously pinned the linter in a separate go.mod file to allow Dependabot to handle automatic updates. Pinning it in the YAML file instead prevents these updates. 😞

We also need to ensure that setup-go's cache handles the linter properly by including its go.sum file in the cache configuration (as described here) and ensuring the linter cache is stored correctly.

run: make lint
uses: golangci/golangci-lint-action@v6
with:
version: v1.59.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we are using higher version

github.com/golangci/golangci-lint v1.63.4

@mmorel-35 mmorel-35 closed this Jan 13, 2025
@mmorel-35 mmorel-35 deleted the build/caches branch January 13, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants