-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for AliCloud monitor #626
Open
chriskery
wants to merge
2
commits into
stakater:master
Choose a base branch
from
chriskery:alicloud_monitor_intergrate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to clarify, this will require us to create an account with Alibaba to run the tests? We need to specify this in our config: - name: AliCloud
apiKey: <ACCESS KEY>
apiToken: <SECRET KEY>
apiURL: "metrics.cn-qingdao.aliyuncs.com" |
yes, we need a alibabaCloud account, then use the account's access creadentials to interact (AKSK). My local test output is : cyw@U-6KPY61TW-0044:s019->/Users/cyw/GolandProjects/IngressMonitorController (0) git:(alicloud_monitor_intergrate)
> export CONFIG_FILE_PATH=$(pwd)/.local/test-config.yaml
git:(alicloud_monitor_intergrate)
cyw@U-6KPY61TW-0044:s019->/Users/cyw/GolandProjects/IngressMonitorController (0) git:(alicloud_monitor_intergrate)
> make test
mkdir -p /Users/cyw/GolandProjects/IngressMonitorController/bin
GOBIN=/Users/cyw/GolandProjects/IngressMonitorController/bin go install sigs.k8s.io/controller-tools/cmd/[email protected]
/Users/cyw/GolandProjects/IngressMonitorController/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
/Users/cyw/GolandProjects/IngressMonitorController/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
GOBIN=/Users/cyw/GolandProjects/IngressMonitorController/bin go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go: downloading sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20250109154033-1de5a3e8bae9
go: downloading sigs.k8s.io/controller-runtime v0.19.4
go: sigs.k8s.io/controller-runtime/tools/[email protected] requires go >= 1.23.0; switching to go1.23.4
/Users/cyw/GolandProjects/IngressMonitorController/bin/setup-envtest use -p path 1.28.x!
/Users/cyw/Library/Application Support/io.kubebuilder.envtest/k8s/1.28.3-darwin-arm64go test ./... -count=1 -coverprofile cover.out
? github.com/stakater/IngressMonitorController/v2 [no test files]
? github.com/stakater/IngressMonitorController/v2/api/v1alpha1 [no test files]
? github.com/stakater/IngressMonitorController/v2/pkg/controllers [no test files]
? github.com/stakater/IngressMonitorController/v2/pkg/kube [no test files]
? github.com/stakater/IngressMonitorController/v2/pkg/kube/util [no test files]
? github.com/stakater/IngressMonitorController/v2/pkg/models [no test files]
ok github.com/stakater/IngressMonitorController/v2/pkg/config 0.414s coverage: 24.5% of statements
ok github.com/stakater/IngressMonitorController/v2/pkg/http 1.638s coverage: 71.4% of statements
ok github.com/stakater/IngressMonitorController/v2/pkg/kube/wrappers 1.098s coverage: 50.8% of statements
ok github.com/stakater/IngressMonitorController/v2/pkg/monitors 1.367s coverage: 8.3% of statements
? github.com/stakater/IngressMonitorController/v2/pkg/secret [no test files]
? github.com/stakater/IngressMonitorController/v2/pkg/util [no test files]
ok github.com/stakater/IngressMonitorController/v2/pkg/monitors/alicloud 8.233s coverage: 59.7% of statements
ok github.com/stakater/IngressMonitorController/v2/pkg/monitors/appinsights 2.088s coverage: 32.7% of statements
ok github.com/stakater/IngressMonitorController/v2/pkg/monitors/gcloud 2.440s coverage: 0.0% of statements [no tests to run]
ok github.com/stakater/IngressMonitorController/v2/pkg/monitors/grafana 1.940s coverage: 0.0% of statements
ok github.com/stakater/IngressMonitorController/v2/pkg/monitors/pingdom 2.280s coverage: 0.0% of statements
ok github.com/stakater/IngressMonitorController/v2/pkg/monitors/pingdomtransaction 2.541s coverage: 14.5% of statements
ok github.com/stakater/IngressMonitorController/v2/pkg/monitors/statuscake 2.899s coverage: 18.9% of statements
ok github.com/stakater/IngressMonitorController/v2/pkg/monitors/updown 3.062s coverage: 0.0% of statements
ok github.com/stakater/IngressMonitorController/v2/pkg/monitors/uptime 2.930s coverage: 11.8% of statements
ok github.com/stakater/IngressMonitorController/v2/pkg/monitors/uptimerobot 2.852s coverage: 5.5% of statements
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for AliCloud monitor.
Refer to : https://www.alibabacloud.com/help/en/cms/user-guide/site-monitoring/