Repository navigation
[5.x] Fix markdown tests - #15162
Merged
Merged
[5.x] Fix markdown tests#15162
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
To be reverted. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Reverts the temporary revert used to confirm CI fails on 5.x. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commonmark 2.9.2 adds
tabindex="-1"to heading permalinks, so that a permalink rendered witharia-hidden="true"isn't left in the keyboard tab order. The markdown tests assert against hardcoded permalink markup, so they started failing as soon as 2.9.2 was released.Rather than hardcoding the new markup, the assertions now strip the attribute before comparing, in the same spirit as the existing newline normalization in the table of contents test. That keeps the tests passing on both 2.9.2 and 2.9.0, which is what
prefer-lowestcurrently resolves to. I didn't want to bump the requirement to an hours-old release on 5.x.This is targeting 5.x even though it's in security-only status, because CI runs would fail.