Fixed bug in setting metrics and metadata (#108)

statisticsnorway · Apr 9, 2024 · 7d9974c · 7d9974c
1 parent 78b4c16
commit 7d9974c
Showing 1 changed file with 11 additions and 13 deletions.
diff --git a/src/main/java/no/ssb/dlp/pseudo/service/pseudo/RecordMapProcessorFactory.java b/src/main/java/no/ssb/dlp/pseudo/service/pseudo/RecordMapProcessorFactory.java
@@ -139,21 +139,19 @@ private String process(PseudoOperation operation,
                 if (isSidMapping && mapFailureMetadata != null) {
                     // There has been an unsuccessful SID-mapping
                     metadataProcessor.addMetric(FieldMetric.MISSING_SID);
-                } else {
-                    metadataProcessor.addMetadata(FieldMetadata.builder()
-                            .shortName(field.getName())
-                            .dataElementPath(field.getPath().substring(1).replace('/', '.')) // Skip leading slash and use dot as separator
-                            .dataElementPattern(match.getRule().getPattern())
-                            .encryptionKeyReference(funcDeclaration.getArgs().getOrDefault(KEY_REFERENCE, null))
-                            .encryptionAlgorithm(match.getFunc().getAlgorithm())
-                            .stableIdentifierVersion(sidSnapshotDate)
-                            .stableIdentifierType(isSidMapping)
-                            .encryptionAlgorithmParameters(funcDeclaration.getArgs())
-                            .build());
-                }
-                if (isSidMapping) {
+                } else if (isSidMapping) {
                     metadataProcessor.addMetric(FieldMetric.MAPPED_SID);
                 }
+                metadataProcessor.addMetadata(FieldMetadata.builder()
+                        .shortName(field.getName())
+                        .dataElementPath(field.getPath().substring(1).replace('/', '.')) // Skip leading slash and use dot as separator
+                        .dataElementPattern(match.getRule().getPattern())
+                        .encryptionKeyReference(funcDeclaration.getArgs().getOrDefault(KEY_REFERENCE, null))
+                        .encryptionAlgorithm(match.getFunc().getAlgorithm())
+                        .stableIdentifierVersion(sidSnapshotDate)
+                        .stableIdentifierType(isSidMapping)
+                        .encryptionAlgorithmParameters(funcDeclaration.getArgs())
+                        .build());
                 return mappedValue;
 
             } else if (operation == DEPSEUDONYMIZE) {