[ANCHOR-766] Add SEP-45 contracts #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lijamie98
reviewed
Jan 14, 2025
soroban/README.md
Outdated
| @@ -0,0 +1,62 @@ | |||
| ## Deploy all contracts | |||
|
|
|||
| One time deployment instructions. If you need to make changes to a previously deployed contract, upgrade it instead (see below). | |||
There was a problem hiding this comment.
Can you make more information of ${MY_ACCOUNT} and how to manage the private key of the account?
There was a problem hiding this comment.
The instructions are generic to the account because I haven't thought through if we want to deploy shared C-account + web auth contracts or if we want to use our own.
| @@ -0,0 +1,62 @@ | |||
| ## Deploy all contracts | |||
There was a problem hiding this comment.
Can you add more information of the purpose of the Rust project? Such as the file structure, purpose of important files, etc?
| @@ -0,0 +1,3 @@ | |||
| # account | |||
|
|
|||
| This implements a custom account that has a single Ed22519 signer. This is used to test the SEP-45 implementation in Anchor Platform. | |||
There was a problem hiding this comment.
Is this to test the SEP-45 implementation?
lijamie98
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds contracts used to test SEP-45.
Context
C-account implementation
Testing
stellar contract buildDocumentation
Adds READMEs for building and deploying the contracts.
Known limitations
The deployment command rejects Ed25519 public keys. I'm not sure if this is a bug with the CLI or something on my end.