init repo structure, build steps, docker steps, etc #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
reviewed
Oct 19, 2023
README.md
Outdated
| `npm i && npm run start` | ||
|
|
||
| ## Production build | ||
| `npm run build:prod` |
There was a problem hiding this comment.
just to be symmetric, we should probably use the yarn cmd's here
There was a problem hiding this comment.
ah thanks!
There was a problem hiding this comment.
fixed in ca47368
piyalbasu
reviewed
Oct 19, 2023
| MAINTAINER SDF Wallets Team <[email protected]> | ||
|
|
||
| RUN mkdir -p /app | ||
| WORKDIR /app |
There was a problem hiding this comment.
do we need to install node and yarn and stuff here? example: https://github.com/stellar/laboratory/blob/master/Dockerfile#L11
There was a problem hiding this comment.
nope, using the node image so they come built in.
piyalbasu
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up the project structure, adds Docker and Make files, and related build steps.