Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] adds blockaid scan tx service method and route #121

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

aristidesstaffieri
Copy link
Contributor

What
Adds blockaid tx scanning and validation

Why
To be used in Freighter when a user signs a tx
Docs: https://docs.blockaid.io/reference/scan_transaction_scan_transaction_post

@aristidesstaffieri
Copy link
Contributor Author

Please don't merge yet, we need to touch base with blockaid for failing API requests.

@stellar-jenkins
Copy link

const NetworkNameBlockaid: { [index: string]: "pubnet" | "futurenet" } = {
PUBLIC: "pubnet",
FUTURENET: "futurenet",
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this include testnet? From their docs, it looked like they support testnet now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from their docs it does look that way but their type here is "pubnet" | "futurenet" so I think maybe that's an open question to bring up with them.

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@blockaid/[email protected] environment, network 0 705 kB blockaiduser

🚮 Removed packages: npm/@blockaid/[email protected]

View full report↗︎

@stellar-jenkins
Copy link

@aristidesstaffieri aristidesstaffieri merged commit 138bd8e into release/1.4.4 Jul 29, 2024
4 checks passed
@aristidesstaffieri aristidesstaffieri deleted the feature/blockaid-tx branch July 29, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants