Feature/scan asset balances #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is available here: |
|
Preview is available here: |
1 similar comment
|
Preview is available here: |
aristidesstaffieri
approved these changes
Aug 4, 2024
aristidesstaffieri
pushed a commit
that referenced
this pull request
Aug 15, 2024
* add isMalicious field to balances * default to setting all balances to isMalicious: false * rm comment * update test name * fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding a
isMaliciousprop to each balance based on scanning each asset with BlockaidWhy
This will allows us to show an icon next to malicious assets in Freighter's FE when showing account balances